Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing constant values prior to execution #1330

Open
hackaugusto opened this issue May 8, 2024 · 0 comments
Open

Allow changing constant values prior to execution #1330

hackaugusto opened this issue May 8, 2024 · 0 comments
Labels
assembly Related to Miden assembly tests Related to tests

Comments

@hackaugusto
Copy link
Contributor

In the protocol account id generation requires PoW. However, for testing, we want to decrease these requirements, otherwise it becomes to slow to run the tests. To reduce the PoW requirements we have to patch both the Rust and the Masm code. The former is done using cfg! and the later is done via patching the MASM code.

The above however has an issue that it is easy to lose the synchronization of said constants, causing test failures that can be time consuming to debug.

To fix the above, ideally we would delay inlining the constants until execution time, allowing the tests to overwrite the source code constants.

@hackaugusto hackaugusto added assembly Related to Miden assembly tests Related to tests labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assembly Related to Miden assembly tests Related to tests
Projects
None yet
Development

No branches or pull requests

1 participant