CURLE_RECV_ERROR was returned in case of a write function error

[Trumeet]

I did this

#define _POSIX_C_SOURCE 200809L

#include <stdio.h>
#include <assert.h>
#include <curl/curl.h>

static size_t cb_curl(void *buffer, size_t size, size_t nmemb, void *userp) {
	return CURL_WRITEFUNC_ERROR; // Or anything != size * nmemb.
}

int main(int argc, char **argv) {
	curl_global_init(CURL_GLOBAL_SSL);
	CURL *curl = curl_easy_init();
	curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, cb_curl);

	curl_easy_setopt(curl, CURLOPT_URL, "https://www.youtube.com/watch?v=dQw4w9WgXcQ");
	CURLcode res = curl_easy_perform(curl);
	printf("Returned %d, should be %d.\n", res, CURLE_WRITE_ERROR);
	fflush(stdout);
	assert(res == CURLE_WRITE_ERROR);

	curl_easy_cleanup(curl);
	curl_global_cleanup();
}

curl_easy_perform() returns CURLE_RECV_ERROR when the write function returns an error.

I expected the following

curl_easy_perform() returns CURLE_WRITE_ERROR as indicated in CURLOPT_WRITEFUNCTION manual.

curl/libcurl version

curl 8.7.1 (x86_64-pc-linux-gnu) libcurl/8.7.1 OpenSSL/3.2.1 zlib/1.3.1 brotli/1.1.0 zstd/1.5.5 libidn2/2.3.7 libpsl/0.21.2 libssh2/1.11.0 nghttp2/1.61.0 nghttp3/1.2.0
Release-Date: 2024-03-27
Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns mqtt pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS brotli GSS-API HSTS HTTP2 HTTP3 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM PSL SPNEGO SSL threadsafe TLS-SRP UnixSockets zstd

operating system

Linux sana.ad.yuuta.moe 6.6.27-1-lts #1 SMP PREEMPT_DYNAMIC Sat, 13 Apr 2024 11:50:59 +0000 x86_64 GNU/Linux

[icing]

I believe this was fixed in 5c59f91. Could you test the current master if this is still happening for you?

[bagder]

@Trumeet's test case above works fine for me in master:

Returned 23, should be 23.

[jay]

Works here with master 7dc376a 2024-05-16 in Windows. (Note: I had to modify the curl_global_init call to use CURL_GLOBAL_ALL to initialize Windows stuff)

curl 8.8.0-DEV (i386-pc-win32) libcurl/8.8.0-DEV OpenSSL/3.0.8 nghttp2/1.52.0
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns ldap ldaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS Debug HSTS HTTP2 HTTPS-proxy IPv6 Largefile NTLM SSL Unicode UnixSockets

[bagder]

Confirmed to work correctly in master anyway.