Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent use of naming Backprop #12515

Closed
Corea opened this issue Aug 23, 2017 · 3 comments · Fixed by #67830
Closed

Inconsistent use of naming Backprop #12515

Corea opened this issue Aug 23, 2017 · 3 comments · Fixed by #67830
Labels
stat:awaiting response Status - Awaiting response from author stat:contribution welcome Status - Contributions welcome type:feature Feature requests

Comments

@Corea
Copy link
Contributor

Corea commented Aug 23, 2017

Describe the problem

Tensorflow code has two types of naming Backprop and BackProp. How about to rename all BackProp to Backprop for consistency?

Source code / logs
@Corea Corea changed the title Inconsistency use of naming Backprop Inconsistent use of naming Backprop Aug 23, 2017
@andydavis1 andydavis1 added stat:awaiting response Status - Awaiting response from author stat:contribution welcome Status - Contributions welcome type:feature Feature requests labels Aug 25, 2017
@ngetahun
Copy link

Hi! I want to make this my first contribution to tensorflow. Has anyone started working on this?

@aseemrb
Copy link

aseemrb commented Aug 26, 2017

Hey @ngetahun, I just started working on this. I can look for another starter issue if you want to pick this up. Saw your comment after I forked. Let me know. Doing a grep -rn . -e 'BackProp' lists some more places other than those mentioned above that we might want to rename from BackProp to Backprop.

@aseemrb aseemrb mentioned this issue Aug 26, 2017
Merged
@Corea
Copy link
Contributor Author

Corea commented Sep 17, 2017

Closed via #12623

@Corea Corea closed this as completed Sep 17, 2017
copybara-service bot pushed a commit that referenced this issue May 15, 2024
@hsharsha @tensorflower-gardener
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
18a5d03 
Imported from GitHub PR openxla/xla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687ea87e38be681cb978d15ebd314377623c4 by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12515 from ROCm:ci_fix_build_break_20240515 499687ea87e38be681cb978d15ebd314377623c4
PiperOrigin-RevId: 633965903
@copybara-service copybara-service bot mentioned this issue May 15, 2024
Closed
copybara-service bot pushed a commit that referenced this issue May 17, 2024
@hsharsha @tensorflower-gardener
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
9b7941d 
Imported from GitHub PR openxla/xla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687ea87e38be681cb978d15ebd314377623c4 by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12515 from ROCm:ci_fix_build_break_20240515 499687ea87e38be681cb978d15ebd314377623c4
PiperOrigin-RevId: 634691871
@copybara-service copybara-service bot mentioned this issue May 17, 2024
Closed
copybara-service bot pushed a commit that referenced this issue May 17, 2024
@hsharsha @tensorflower-gardener
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
9182d0d 
Imported from GitHub PR openxla/xla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687ea87e38be681cb978d15ebd314377623c4 by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12515 from ROCm:ci_fix_build_break_20240515 499687ea87e38be681cb978d15ebd314377623c4
PiperOrigin-RevId: 633993125
@copybara-service copybara-service bot mentioned this issue May 17, 2024
Merged
copybara-service bot pushed a commit that referenced this issue May 17, 2024
@hsharsha @tensorflower-gardener
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
d05b43f 
Imported from GitHub PR openxla/xla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687ea87e38be681cb978d15ebd314377623c4 by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12515 from ROCm:ci_fix_build_break_20240515 499687ea87e38be681cb978d15ebd314377623c4
PiperOrigin-RevId: 633993125
copybara-service bot pushed a commit that referenced this issue May 17, 2024
@hsharsha @tensorflower-gardener
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
f2a5d30 
Imported from GitHub PR openxla/xla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687ea87e38be681cb978d15ebd314377623c4 by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12515 from ROCm:ci_fix_build_break_20240515 499687ea87e38be681cb978d15ebd314377623c4
PiperOrigin-RevId: 633993125
copybara-service bot pushed a commit that referenced this issue May 17, 2024
@hsharsha @tensorflower-gardener
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
cd5779d 
Imported from GitHub PR openxla/xla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687ea87e38be681cb978d15ebd314377623c4 by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

PiperOrigin-RevId: 634713247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stat:awaiting response Status - Awaiting response from author stat:contribution welcome Status - Contributions welcome type:feature Feature requests
Projects
None yet
Milestone
No milestone
4 participants
@Corea @aseemrb @ngetahun @andydavis1