Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Incompatibility with the Rtree library. #45359

Open
decadance-dance opened this issue May 15, 2024 · 2 comments
Open

[Core] Incompatibility with the Rtree library. #45359

decadance-dance opened this issue May 15, 2024 · 2 comments
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. P1 Issue that should be fixed within a few weeks

Comments

@decadance-dance
Copy link

What happened + What you expected to happen

It dosen't work with rtree index structure from python Rtree library.
When I create the index in one remote func and pass it as input to another func I won't get the same index.
I expect that the index object to be stable (not changed) between remote funcs.

Versions / Dependencies

Rtree==1.2.0
ray==2.20.0

Python 3.10

Reproduction script

import ray
from rtree import index as rindex


def make_rtree_index():
    ridx = rindex.Index()
    ridx.insert(0, [0, 10, 20, 30])
    return ridx


def show_rtree(rtree):
    print(rtree.bounds)


if __name__ == "__main__":

    # Run wo/ ray
    rtree = make_rtree_index()
    show_rtree(rtree)


    # Run w/ ray
    ray.init(local_mode=True)

    make_rtree_index = ray.remote(make_rtree_index)
    show_rtree = ray.remote(show_rtree)

    rtree = make_rtree_index.remote()
    show_rtree.remote(rtree)

Issue Severity

Medium: It is a significant difficulty but I can work around it.

@decadance-dance decadance-dance added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels May 15, 2024
@982945902
Copy link
Contributor

I can't reproduce this problem in the current mainline, maybe you can try the latest source code installation, or version 2.22.0

@anyscalesam anyscalesam added the core Issues that should be addressed in Ray Core label May 20, 2024
@rynewang
Copy link
Contributor

Can you retry with ray 2.22.0 and print the result differences? Thanks

@rynewang rynewang added P1 Issue that should be fixed within a few weeks @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

4 participants