Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation without h2o, cloud enabled #17673

Merged
merged 1 commit into from
May 17, 2024

Conversation

stelfrag
Copy link
Collaborator

Summary

Check compilation with h2o and cloud disabled. It should build properly now

Fixes #17632

@stelfrag stelfrag marked this pull request as ready for review May 16, 2024 07:38
@stelfrag stelfrag requested review from vkalintiris, a team and thiagoftsm as code owners May 16, 2024 07:38
@stelfrag stelfrag removed the request for review from a team May 16, 2024 08:30
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could compile this PR locally with both or only one disabled, LGTM!

@stelfrag stelfrag merged commit 95f370b into netdata:master May 17, 2024
145 of 149 checks passed
@stelfrag stelfrag deleted the fix_compile_without_h2o_cloud branch May 17, 2024 08:27
stelfrag added a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Netdata 1.45.4 fails to build with h2o, cloud and aclk disabled
2 participants