Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backend cancelling logic #8280

Open
1 task done
freddyaboulton opened this issue May 13, 2024 · 0 comments
Open
1 task done

Refactor backend cancelling logic #8280

freddyaboulton opened this issue May 13, 2024 · 0 comments
Labels
refactor Involves refactoring existing code

Comments

@freddyaboulton
Copy link
Collaborator

freddyaboulton commented May 13, 2024

  • I have searched to see if a similar issue already exists.

Is your feature request related to a problem? Please describe.

See this comment by @aliabid94

#8260 (review)

Describe the solution you'd like
Now that we keep track of of which BlockFns cancel events via the is_cancel_fn prop, I think we can modify the front end logic to send a request to the /cancel endpoint directly.

Additional context
Add any other context or screenshots about the feature request here.

@freddyaboulton freddyaboulton added the refactor Involves refactoring existing code label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Involves refactoring existing code
Projects
None yet
Development

No branches or pull requests

1 participant