Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSV_UPLOAD_MAX_SIZE config #28400

Open
dpgaspar opened this issue May 9, 2024 · 0 comments
Open

Remove CSV_UPLOAD_MAX_SIZE config #28400

dpgaspar opened this issue May 9, 2024 · 0 comments
Assignees

Comments

@dpgaspar
Copy link
Member

dpgaspar commented May 9, 2024

CSV_UPLOAD_MAX_SIZE only affects CSV uploads as the name implies, yet we have Excel and columnar upload also.
Also this prevention should be made at the webserver level using max_body_size or similar.

there are some trade offs here:
pros:

  • Usually faster and more efficient as the web server can reject the request before it reaches the application code.
  • Helps to prevent denial-of-service attacks by limiting resource consumption.
    cons:
  • does not provide a nice server response
@dpgaspar dpgaspar self-assigned this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposals - Not proposed for consensus
Development

No branches or pull requests

1 participant