Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAG list: filter FAILED/RUNNING #39675

Closed
1 of 2 tasks
ecodina opened this issue May 17, 2024 · 3 comments · Fixed by #39701
Closed
1 of 2 tasks

DAG list: filter FAILED/RUNNING #39675

ecodina opened this issue May 17, 2024 · 3 comments · Fixed by #39701
Assignees
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests

Comments

@ecodina
Copy link
Contributor

ecodina commented May 17, 2024

Description

A few versions ago a very useful feature was introduced: allowing users to filter the home (DAG list) by RUNNING or FAILED DAGs. However, when you click on FAILED, all dags appear, even paused ones.

image

I believe the two sets of buttons should "work together". Therefore:

  • All + Failed: show all failed DAGs (paused and unpaused)
  • Active + Failed: only show active failed DAGs
  • ....

Use case/motivation

We have many paused DAGs that finished with an error. It would be very useful to not see them so that it is easier to check actual errors.

Related issues

I've tried to find the PR that introduced this, but couldn't find it.

Thanks!

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ecodina ecodina added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels May 17, 2024
@eladkal
Copy link
Contributor

eladkal commented May 17, 2024

I've tried to find the PR that introduced this, but couldn't find it.

cc @PApostol as the original author of this feature #30429 WDYT?

@ecodina
Copy link
Contributor Author

ecodina commented May 17, 2024

Thanks @eladkal for finding it! Following your concern (mixing Dag and DagRun properties) I believe that adding this should be "simple":

Instead of having:
arg_status_filter = request.args.get("status")

We should have

arg_status_filter = request.args.get("status")  # all, active, paused
arg_lastrun_filter = request.args.get("lastrunstatus")   # failed or running

Then, since we already have the queries (all_dags, active_dags, paused_dags, running_dags, failed_dags) it would be a matter of filtering the last two objects.

@PApostol
Copy link
Contributor

This is a good idea. At the moment, "Failed" tab doesn't distinguish between "All", "Active" or "Paused" (same applies for "Running" but that's probably less relevant). It would be nice for the tabs to work together.

@nathadfield nathadfield added area:UI Related to UI/UX. For Frontend Developers. and removed needs-triage label for new issues that we didn't triage yet labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants