Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add median duration markline to dag run duration page #39667

Open
1 of 2 tasks
tirkarthi opened this issue May 16, 2024 · 1 comment
Open
1 of 2 tasks

Add median duration markline to dag run duration page #39667

tirkarthi opened this issue May 16, 2024 · 1 comment
Labels
affected_version:main_branch Issues Reported for main branch area:UI Related to UI/UX. For Frontend Developers. good first issue kind:feature Feature Requests

Comments

@tirkarthi
Copy link
Contributor

Description

Task duration chart already has median run and queued duration values as markline using echarts. However dag run duration had issues implementing this since the show landing pages is a checkbox that dynamically adds another series and due to an issue in echarts the markline was not rendering properly. Using clear method works but it loses the animations and reduces UX. Ref comments.

Since legends are clickable to show and hide corresponding series a proposed solution would be to have landing duration added by default along with legend but have it disabled by default. Users who need it can click on the legend to enable it and the series will be rendered. This is similar to using a checkbox except using legends and the selection can be saved to persist between pages if there are no issues like the dynamic series update as above.

#38434 (comment)
#38434 (comment)

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@tirkarthi tirkarthi added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels May 16, 2024
@eladkal eladkal added good first issue area:UI Related to UI/UX. For Frontend Developers. affected_version:main_branch Issues Reported for main branch and removed needs-triage label for new issues that we didn't triage yet labels May 25, 2024
@tirkarthi
Copy link
Contributor Author

I tried an attempt at this to make this similar to task duration page but in many cases like catchup the landing page time is in days so days is applied as a unit and the actual runs which are complete in the order of minutes will be displayed on the scale of days which is not good UX. The primary issue is that landing times and dag run duration would have different units and to scale them based on selection which is not the case with task duration since the run duration is the primary field for unit with queued duration mostly in seconds to minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:main_branch Issues Reported for main branch area:UI Related to UI/UX. For Frontend Developers. good first issue kind:feature Feature Requests
Projects
None yet
Development

No branches or pull requests

2 participants