samples: net: tftp-client: Configs cleanup #72919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
jukkar,
kartben,
nashif,
pdgendt,
ssharks and
tbursztyka
As native_posix is no longer supported, due to incompatibility with CONFIG_POSIX_API, remove a dedicated config for it. A config for qemu_cortex_m3 needed to enable RNG, as otherwise it's not available for the platform and gives build error. Finally, enable qemu_cortex_m3 build in the CI. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
force-pushed
the
net/sample-tftp-client-config-cleanup
branch
from
8e7aca4
to
b6c6c8b
Compare
A support for RDNSS option should not force DNS subsystem being enabled in the system, especially that the option is enabled by default. It should work the other way around - the option is supported only if DNS was enabled by the user. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
force-pushed
the
net/sample-tftp-client-config-cleanup
branch
from
b6c6c8b
to
89d67f2
Compare
jukkar
approved these changes
May 17, 2024
| @@ -159,7 +159,7 @@ config NET_IPV6_DAD | |||
| config NET_IPV6_RA_RDNSS | |||
| bool "Support RA RDNSS option" | |||
| depends on NET_IPV6_ND | |||
| select DNS_RESOLVER | |||
| depends on DNS_RESOLVER | |||
There was a problem hiding this comment.
Nice, I wondered exactly this weirdness in #72834 just few minutes ago. Good that it is now fixed.
There was a problem hiding this comment.
@rlubos Wow! What an unbelievable coincidence - just found the same issue and tried disabling NET_IPV6_RA_RDNSS, as I don't use DNS_RESOLVER in my app. Your solution is definitely better and more desirable. Thank you!
LuDuda
approved these changes
May 17, 2024
| @@ -159,7 +159,7 @@ config NET_IPV6_DAD | |||
| config NET_IPV6_RA_RDNSS | |||
| bool "Support RA RDNSS option" | |||
| depends on NET_IPV6_ND | |||
| select DNS_RESOLVER | |||
| depends on DNS_RESOLVER | |||
There was a problem hiding this comment.
@rlubos Wow! What an unbelievable coincidence - just found the same issue and tried disabling NET_IPV6_RA_RDNSS, as I don't use DNS_RESOLVER in my app. Your solution is definitely better and more desirable. Thank you!
pdgendt
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
Fixes #72907