Headers not mapped from Umbrella header when productName is nil

[BilalSaifudeen]

What problem or need do you have?

For some of our framework targets we have umbrella headers and we want to generate headers from it.

We don't specify productName for these targets as productName in ProjectDescription.Target is optional. As the documentation says, the name would be taken in case it is nil.

But, when headers are generated with .allHeaders(from: umbrella:) method, it doesn't map headers if the import is in the form import <ModuleName\Header.h>. It works for imports in the form of import "Header.h"

Digging into Tuist, we found that it is due to missing productName. And we fixed it by passing productName.

Is it expected to pass productName explicitly if we want to match modular headers from umbrella?

Or it is because it is missed to take name incase of productName is nil in Target+ManifestMapper.swift

Potential solution

Use name when productName is nil for header generation.

macOS version

14.4.1

Tuist version

4.9.0

Xcode version

15.2

[fortmarek]

Hey 👋

Or it is because it is missed to take name incase of productName is nil in Target+ManifestMapper.swift

Yeah, it's possible this is a bug on our side. Thanks for digging into this.

Would you mind creating a reproducible sample to make the example more concrete? And if you feel like, you can create a draft PR with your proposed solution 🙂