Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tuist prints out warnings when using Braze #6289

Closed
anlaital-oura opened this issue May 15, 2024 · 4 comments · Fixed by #6290
Closed

Tuist prints out warnings when using Braze #6289

anlaital-oura opened this issue May 15, 2024 · 4 comments · Fixed by #6290
Labels
type:bug Something isn't working

Comments

@anlaital-oura
Copy link
Collaborator

What happened?

Running tuist generate when having Braze as a dependency will print out warnings.

This is regression between Tuist 4.11.0 and 4.13.0. I did not check if this happens with 4.12.0.

How do we reproduce it?

  1. Add Braze as a dependency .package(url: "https://github.com/braze-inc/braze-swift-sdk", exact: "7.3.0")
  2. Run tuist install && tuist generate and you will observe the warnings

Error log

The following warnings need attention:
 · Invalid product name 'braze-swift-sdk_BrazeUI'. This string must contain only alphanumeric (A-Z,a-z,0-9), and underscore (_) characters.
 · Invalid product name 'braze-swift-sdk_BrazeKitResources'. This string must contain only alphanumeric (A-Z,a-z,0-9), and underscore (_) characters.

macOS version

14.4.1

Tuist version

4.13.0

Xcode version

15.3
@anlaital-oura anlaital-oura added the type:bug Something isn't working label May 15, 2024
@pepicrft
Copy link
Contributor

@anlaital-oura does the project compile despite the warning?

@pepicrft
Copy link
Contributor

Very likely addressed by this PR

@kapitoshka438
Copy link
Contributor

kapitoshka438 commented May 15, 2024 •
edited

Very likely addressed by this PR

Not really.
I think this is caused by this change.
I could add a fix to my PR just by adding hyphen to allowed characters here but I believe @danibachar has already volunteered.

@anlaital-oura
Copy link
Collaborator Author

@pepicrft the project compiles fine.

@kapitoshka438 kapitoshka438 mentioned this issue May 15, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix target linter warnings for target products that allow dots and hyphens kapitoshka438/tuist
3 participants
@pepicrft @kapitoshka438 @anlaital-oura