Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Serialization over a data generated by prisma #2415

Open
victorsmits opened this issue Aug 26, 2023 · 7 comments
Open

[BUG] Serialization over a data generated by prisma #2415

victorsmits opened this issue Aug 26, 2023 · 7 comments

Comments

@victorsmits
Copy link

victorsmits commented Aug 26, 2023

The response serialization is not working when you get data through the generated prisma repository but work as expected when you pass by the prisma service

Information

  • Version: 7.x
  • Packages:
  • prisma

A few sentences describing the overall goals of the issue.

Example with prisma repository

export class ProfilePlayerModel {
  @Property()
  playerFirstName: string;
  
  @Property()
  playerID: number;
  
  @Property()
  playerLastName: string;
}

export class ProfileModel {
  @Property()
  DiscordId: string;
  
  @Property()
  SteamId: string;
  
  @Property()
  DiscordName: string;
  
  @CollectionOf(() => ProfilePlayerModel)
  @ForwardGroups()
  player: ProfilePlayerModel;
}

@Controller('/profile')
@UseBefore(JwtMiddleware)
export class ProfileController {
  @Inject()
  protected account: AccountsRepository;
  
  @Inject()
  protected players: PlayersRepository;
  
  @Get('/')
  @Returns(200, ProfileModel)
  async getProfile(@Req() req: Req) {
    const player = await this.players.findFirst({
      where: {
        active: 1,
        archived: false,
      },
      include: {},
    });
    
    return {
      ...req.user,
      player: player,
    };
  }
}

response

{
   "DiscordId": "543046299826520074",
   "SteamId": "1100001062b26b4",
   "DiscordName": "VictorSmits",
   "player": {
       "playerID": 1,
       "steamID": "11000013d4ab95d",
       "active": 1,
       "playerLastName": "Light",
       "playerFirstName": "Ryan",
       "playerBirthYear": 1985,
       "playerBirthMonth": 12,
       "playerBirthDay": 26,
       "playerGender": "Homme",
       "playerFatherFace": 0,
       "playerMotherFace": 0,
       "playerHeredityHead": 0,
       "playerHeredityBody": 0,
       "playerHairStyle": 3,
       "playerHairColor": 8,
       "playerHairHighlightColor": 29,
       "playerEyebrowsStyle": 0,
       "playerEyebrowsColor": 0,
       "playerEyesColor": 0,
       "playerBeardStyle": 15,
       "playerBeardColor": 3,
       "playerAgeingStyle": 16,
       "playerChestHairStyle": 255,
       "playerChestHairColor": 0,
       "makeUpStyle": 255,
       "makeUpType": 0,
       "makeUpColor1": 0,
       "makeUpColor2": 0,
       "paintStyle": 255,
       "paintType": 0,
       "paintColor1": 0,
       "paintColor2": 0,
       "lipStyle": 255,
       "lipType": 0,
       "lipColor1": 0,
       "lipColor2": 0,
       "stain6Style": 255,
       "stain7Style": 255,
       "stain9Style": 255,
       "stain0Style": 255,
       "stain11Style": 255,
       "archived": false,
       "createDate": "2021-04-28T13:19:54.000Z",
       "updated_at": "2021-04-28T13:19:54.000Z"
   }
}

Example with prisma service

export class ProfilePlayerModel {
  @Property()
  playerFirstName: string;
  
  @Property()
  playerID: number;
  
  @Property()
  playerLastName: string;
}

export class ProfileModel {
  @Property()
  DiscordId: string;
  
  @Property()
  SteamId: string;
  
  @Property()
  DiscordName: string;
  
  @Property()
  @ForwardGroups()
  player: ProfilePlayerModel;
}

@Controller('/profile')
@UseBefore(JwtMiddleware)
export class ProfileController {
  @Inject()
  protected prisma: PrismaService;
  
  @Get('/')
  @Returns(200, ProfileModel)
  async getProfile(@Req() req: Req) {
    const player = await this.prisma.players.findFirst({
      where: {
        active: 1,
        archived: false,
      },
      include: {},
    });
    
    return {
      ...req.user,
      player,
    };
  }
}

response

{
    "DiscordId": "543046299826520074",
    "SteamId": "1100001062b26b4",
    "DiscordName": "VictorSmits",
    "player": {
        "playerFirstName": "Ryan",
        "playerID": 1,
        "playerLastName": "Light"
    }
}
@Romakita
Copy link
Collaborator

Romakita commented Sep 28, 2023

@victorsmits
Copy link
Author

Hello I have update my project to the latest version and now I have an other issue it seams that the repositories are not instantiate and thus its impossible to call them.

"TypeError: Cannot read properties of undefined (reading 'findMany')\n" +
' at MessengerGroupsRepository.findMany (C:\Users\victo\Documents\21JumpClick\tablet-api\node_modules\@tSed\prisma\lib\cjs\.schema\repositories\MessengerGroupsRepository.js:37:43)\n' +
' at MessengerController.getGroup (C:\Users\victo\Documents\21JumpClick\tablet-api\src\controllers\rest\messenger.controller.ts:74:32)\n' +
' at C:\Users\victo\Documents\21JumpClick\tablet-api\node_modules\@tSed\platform-params\src\builder\PlatformParams.ts:57:36'

@Romakita
Copy link
Collaborator

Romakita commented Sep 30, 2023

@victorsmits are you sure you have updated all dependencies correctly? Because I haven’t deployed fix on prisma.
There is no change.

@victorsmits
Copy link
Author

Yes all my dependencies are up to date.

image

@Romakita
Copy link
Collaborator

Romakita commented Oct 1, 2023

I suggest you to create repository to reproduce the issue. Also can bump your packages progressively to find the version responsible to your issue.
see you

@Romakita
Copy link
Collaborator

Romakita commented Oct 2, 2023

All works for me:
https://github.com/tsedio/tsed-example-prisma

DB start and serialization works. But I haven't tested your specific use case. I'll try to create the same case.

@Romakita
Copy link
Collaborator

Romakita commented Nov 2, 2023

Note: Problem around the prisma schema when the table name is on snake case format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

2 participants