Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WBWIIterator to MergingIterator #51

Open
rockeet opened this issue Aug 16, 2023 · 1 comment
Open

Add WBWIIterator to MergingIterator #51

rockeet opened this issue Aug 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@rockeet
Copy link
Collaborator

rockeet commented Aug 16, 2023

Now Transaction DB use BaseDeltaIterator, but it needs compare base_iter key and delta_iter key on each Next()/Prev(), this waste CPU.

We can add delta iter to the (heap of) underlying MergingIterator of DBIter, thus improving performance -- delta iter is unlikely going to heap top.

@rockeet rockeet added the enhancement New feature or request label Aug 16, 2023
rockeet added a commit that referenced this issue Aug 16, 2023
rockeet added a commit that referenced this issue Aug 16, 2023
rockeet added a commit that referenced this issue Aug 16, 2023
rockeet added a commit that referenced this issue Aug 16, 2023
@rockeet
Copy link
Collaborator Author

rockeet commented Aug 17, 2023

Unfortunately, BeginTransaction() does not alloc a seq num, this makes WBWIIterator can not take a seq num as virtual seq num to be used by MergingIterator's heap comparator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant