Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

substitute-constants defined twice #471

Closed
lgrapenthin opened this issue May 17, 2024 · 1 comment
Closed

substitute-constants defined twice #471

lgrapenthin opened this issue May 17, 2024 · 1 comment

Comments

@lgrapenthin
Copy link

lgrapenthin commented May 17, 2024 •
edited

datascript/src/datascript/query.cljc

Line 402 in 61edb9e

(defn substitute-constants [context pattern]

This gives a compiler warning. It could be avoided by choosing a different name for the wrapped version.

Addendum: There is another function called substitute-constant in the same namespace that appears to be defined twice as well.
tonsky added a commit that referenced this issue May 23, 2024
@tonsky
Remove duplicate code #471
995f8a2
@tonsky
Copy link
Owner

tonsky commented May 23, 2024

Thanks!

@tonsky tonsky closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonsky @lgrapenthin