Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email security notifications #1030

Open
FlxMgdnz opened this issue Sep 21, 2023 · 11 comments
Open

Email security notifications #1030

FlxMgdnz opened this issue Sep 21, 2023 · 11 comments
Assignees
Labels
enhancement New feature or request go Pull requests that update Go code good first issue Good for newcomers

Comments

@FlxMgdnz
Copy link
Member

FlxMgdnz commented Sep 21, 2023

Currently, Hanko backend only sends emails for passcode authentication.

Add a new config option to enable / disable account security notifications.

If enabled, send security notification emails to the user's primary email address on

  • Password changed
  • Email address added
  • Primary email address changed (use primary email before the change)
  • Passkey created
@FlxMgdnz FlxMgdnz added enhancement New feature or request good first issue Good for newcomers go Pull requests that update Go code Hacktoberfest Suited for Hacktoberfest contributions labels Sep 21, 2023
@irby
Copy link
Collaborator

irby commented Sep 23, 2023

@FlxMgdnz Would we want to configure each of these scenarios individually?

@irby
Copy link
Collaborator

irby commented Sep 26, 2023

@FlxMgdnz I’ll take on this item

@FlxMgdnz
Copy link
Member Author

@FlxMgdnz Would we want to configure each of these scenarios individually?

@irby I think it would be better to be able to toggle each warning individually, yes.

@prashantug21
Copy link

@FlxMgdnz Is this issue available?

@Fer-Win
Copy link

Fer-Win commented Oct 10, 2023

@FlxMgdnz If no is currently working on it or you would want someone else to work on it. Let me try it please..Assign it to me...

@irby
Copy link
Collaborator

irby commented Oct 10, 2023

@Fer-Win I am currently working on this one. About 80% done, ran into an issue I'm working to resolve before I can get a PR up :)

@Fer-Win
Copy link

Fer-Win commented Oct 10, 2023

@irby ok fine, let me know if any other issue opens up

@irby
Copy link
Collaborator

irby commented Oct 21, 2023

@FlxMgdnz I'm assuming emails sent out should be recorded in an audit log, correct?

Do we want to refactor the SMTP settings? Currently, these configuration settings are setup under passcode, but obviously as we include security notifications these will no longer only apply to passcodes.

@FlxMgdnz
Copy link
Member Author

@irby yes we should log the emails.

SMTP settings refactoring makes sense imho.

@irby
Copy link
Collaborator

irby commented Oct 21, 2023

@FlxMgdnz It'll make sense to break out the SMTP settings refactor into its own PR. Do you want me to create an issue for this change, or can I link it to this issue?

@FlxMgdnz
Copy link
Member Author

Right, that makes sense. Linking to this issue/comment should be sufficient. Thanks @irby !

@FlxMgdnz FlxMgdnz removed the Hacktoberfest Suited for Hacktoberfest contributions label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code good first issue Good for newcomers
Projects
Status: 🔖 Up next
Development

No branches or pull requests

4 participants