Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the current track has no artwork then the favicon is not reset #9

Open
dhowden opened this issue Apr 17, 2015 · 3 comments
Open
Labels

Comments

@dhowden
Copy link
Member

dhowden commented Apr 17, 2015

No description provided.

@dhowden dhowden added the bug label Apr 17, 2015
@solarnz
Copy link
Contributor

solarnz commented Apr 24, 2015

If the favicon is a 404, it won't update the image.

@dhowden
Copy link
Member Author

dhowden commented Apr 24, 2015

Yes, so I guess there are two issues here: if there is no track selected OR if there is no artwork then the icon should be reset to the default value.

With the empty selection I tried removing the href attribute on the favicon <link> tag but it didn't clear it... Tried a few more things without success, but I'm sure there will be a way.

@solarnz
Copy link
Contributor

solarnz commented Apr 24, 2015

The problem is that once the browser gets a valid favicon, then it will continue to use that if the favicon url cannot be found (either 404, or the element doesn't exist).

I think we will need a default image to show in place.

Maybe we could hit two issues on the head at the same time if we have a default album art image for those files that don't have one set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants