Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: support github markdown #162

Open
kiwicopple opened this issue Jan 7, 2024 · 2 comments
Open

docs: support github markdown #162

kiwicopple opened this issue Jan 7, 2024 · 2 comments

Comments

@kiwicopple
Copy link
Member

Chore

Describe the chore

dbdev deoesn't support all of gh flavored markdown:

image

Additional context

https://database.dev/kiwicopple/supa_audit

from this extension:

https://github.com/supabase/supa_audit

@imor
Copy link
Contributor

imor commented Jan 8, 2024

Looks like raw html is not supported currently. If I add set skipHtml={true} in the props of the ReactMarkdown component, the above README renders correctly. But this sounds dangerous because it might open up possibility of XSS attacks. Although I couldn't get it to render a <script> tag, so it does filter out some tags. @alaister do you know how safe will it be to set skipHtml={true}?

@alaister
Copy link
Member

alaister commented Jan 9, 2024

Yes, I think skipHtml seems to be only for trusted environments: https://github.com/remarkjs/react-markdown?tab=readme-ov-file#appendix-a-html-in-markdown

I'll investigate what the proper method is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants