Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing query string params is a bit odd. #8

Open
cigzigwon opened this issue May 10, 2023 · 0 comments
Open

Parsing query string params is a bit odd. #8

cigzigwon opened this issue May 10, 2023 · 0 comments

Comments

@cigzigwon
Copy link

cigzigwon commented May 10, 2023

To me it seems odd to pass query params as an enum since they are already in the URL we sent to the lib. My problem is that I have a webserver w/large gzipped assets that only allows me to download with a bad query string.

ie. &Expires=1687269643&Signature=A0rGvq2fJZXfmDDJK-gut5jntqQ9lDFDOMH~WEov8t8z3R174eC0QXDsBR9sNeIRENR2AsWobhscdk8pcHD6uCUeQqRC05Opkr3QYrh-xJyoOm-0ZCpQLIeVMHFAUDyaDJkFx4ERNRU-piLISaKzbJzUl15zqUkaV-T5dcCxRuuLtWssY1tnZS-X3b95HZGqBLbyXiltsEj8s~njxiLPhf26uQajE3IWp-YXu4oS21Ab0onNzZmUTDIhvt3rL-c4MBE6P5lys-5biYgONAJtIVN~JWGUexB2ZdLejk0KCVSlM4R71Ou7UoIAesAX5ZYZT~MhIqzQzEVZgiPMzgnaZg__&Key-Pair-Id=K27TQMT39R1C8A

I just re-implement the library but it looks like this is still a bit raw and depending on the webserver we don't get valid responses so we have to use cURL as a fallback. I've had cases where the file I'm trying to get needs to be resumed in Chrome after failure. I don't expect this lib to handle that case. I'm just saying that in some cases we are doomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant