Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable URL in Springwolf UI #757

Open
madrimas opened this issue May 16, 2024 · 8 comments
Open

Configurable URL in Springwolf UI #757

madrimas opened this issue May 16, 2024 · 8 comments
Labels
enhancement New feature or request staged for release

Comments

@madrimas
Copy link

madrimas commented May 16, 2024

It would be nice to have an option to configure custom URL for Springwolf UI. E.g.: springwolf.ui.url=/custom/url

Without the feature there is no option to use the UI in multi-services projects - the flagship example is k8s environment with many microservices based on the same baseUrl. So I want to have a possibility to configure UI url like that: baseUrl + myMicroserviceId + ui.html.

From my perspective the solution can be based on Swagger UI solution.

I don't know if any alternative will be sufficient, from my perspective is a missing key feature.

@madrimas madrimas added the enhancement New feature or request label May 16, 2024
Copy link

Welcome to Springwolf. Thanks a lot for reporting your first issue. Please check out our contributors guide and feel free to join us on discord.

@sam0r040
Copy link
Collaborator

Hi @madrimas,
do you ask for an option to select different api backend in a single ui. Similar to the option in swagger (https://petstore3.swagger.io/):
image
Or do want to manually configure the springwolf paths by setting the spring context path property?
Or is it something different? If so, could you point us to the swagger docs?

@sam0r040 sam0r040 added the waiting for feedback Waiting for user feedback/response label May 17, 2024
@madrimas
Copy link
Author

madrimas commented May 17, 2024

Hi @sam0r040! Thanks for quick reply!

Something different. I want to set custom path without setting spring context path in whole app.
In swagger UI there is:
springdoc.swagger-ui.path - where you can set custom path, in my case {myMicroserviceId} + custom-path

then I can get swagger UI in my browser via such URL: {someBaseUrl, eg. k8s cluster, or localhost} / {myMicroserviceId} / custom-path / swagger-ui / index.html, e.g. localhost/pet-service/custom-path/swagger-ui/index.html

In Springwolf I want to configure it in the similar way, e.g.:
springwolf.ui.path=/{myMicroserviceId}/custom-path/

then I'll get Springwolf UI in my browser via such URL: localhost/pet-service/custom-path/springwolf/asyncapi-ui.html instead of localhost/springwolf/asyncapi-ui.html

So, as I said, it's similar case to context path, but without setting it (due to some requirements, I cannot set context path in the whole app).

@github-actions github-actions bot removed the waiting for feedback Waiting for user feedback/response label May 17, 2024
@madrimas
Copy link
Author

so @sam0r040 how do you see that? Is there a possibility to add such feature?

@sam0r040
Copy link
Collaborator

Hi @madrimas, we are currently looking into this feature.

@madrimas
Copy link
Author

madrimas commented Jun 6, 2024

Hi @sam0r040, that's great! I look forward to hearing more good news

Copy link

github-actions bot commented Jun 7, 2024

The change is staged for release and will be part of the next release.

If you want to try and verify it in your application today,
use the latest 1.X.0-SNAPSHOT build as described in our README.md > Testing SNAPSHOT version

Thank you for the report/contribution!

@madrimas
Copy link
Author

I've tested the snapshot, looks brilliant, thanks!

After release I'll check it once again and then close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request staged for release
Projects
None yet
Development

No branches or pull requests

2 participants