Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Expected a valid CSS identifier #123

Open
djkato opened this issue Nov 30, 2023 · 4 comments
Open

[bug] Expected a valid CSS identifier #123

djkato opened this issue Nov 30, 2023 · 4 comments
Labels
bug Something isn't working investigating Not quite sure if it's valid, yet

Comments

@djkato
Copy link

djkato commented Nov 30, 2023

Describe the bug
node_modules/svelte-range-slider-pips/src/RangeSlider.svelte:686:73 Expected a valid CSS identifier

To Reproduce

create new astro project, install svelte (Installs 5.0.0-next.1), try to use like:

<RangeSlider {max} {min} step="1" pushy={true} values={[50]} />

Screenshots
image

@djkato djkato added bug Something isn't working investigating Not quite sure if it's valid, yet labels Nov 30, 2023
@simeydotme
Copy link
Owner

thanks, when Svelte5 is released, I'll have to look at this :)

@serferdinand2
Copy link

Describe the bug node_modules/svelte-range-slider-pips/src/RangeSlider.svelte:686:73 Expected a valid CSS identifier

To Reproduce

create new astro project, install svelte (Installs 5.0.0-next.1), try to use like:

<RangeSlider {max} {min} step="1" pushy={true} values={[50]} />

Screenshots image

I believe this was fixed in the latest release https://github.com/sveltejs/svelte/releases/tag/svelte%405.0.0-next.38

@simeydotme
Copy link
Owner

oh it was actually a bug in Svelte, not a design change? :D
thanks for sharing that!

@serferdinand2
Copy link

I might be wrong about this but |global has issues in svelte 5. Right now it deletes the whole DOM on global transitions..

@simeydotme simeydotme added this to the Svelte 4+ , Typescript milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigating Not quite sure if it's valid, yet
Projects
None yet
Development

No branches or pull requests

3 participants