Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Broken links on docs site #118

Open
sortbyfirstname opened this issue Oct 21, 2023 · 3 comments
Open

[docs] Broken links on docs site #118

sortbyfirstname opened this issue Oct 21, 2023 · 3 comments
Labels
bug Something isn't working investigating Not quite sure if it's valid, yet

Comments

@sortbyfirstname
Copy link

Describe the bug
There are some broken links on the docs site.

Sidebar:

  • Pips link within Options does not navigate to the pips prop in the article.
  • Range link within Options does not navigate to the range prop in the article.

Examples:

  • All 'Recipe' style links on the Examples page are broken, resulting in a 404.

Recipes:

  • All 'Recipe' style links on the Recipes page are broken, resulting in a 404.
  • The 'Recipe' style links have broken images.
@sortbyfirstname sortbyfirstname added bug Something isn't working investigating Not quite sure if it's valid, yet labels Oct 21, 2023
@simeydotme
Copy link
Owner

thank you @sortbyfirstname !!
I rushed this out before a vacation / new job and I didn't get a chance to fully QA it.
but I deemed it was better than the previous one so just "shipped it" :D

really appreciate the feedback

@simeydotme
Copy link
Owner

The PR didn't fix the broken links in the Recipes/Examples landing pages, @sortbyfirstname ... I'll take a deeper look later. There's something weird with the way the base interacts with them

@sortbyfirstname
Copy link
Author

That is weird, sorry about that - "worked on my machine" 😅. I'll admit this was my first time dealing with Astro, will have another look when I get a chance as well.

@simeydotme simeydotme changed the title [bug] Broken links on docs site [docs] Broken links on docs site Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigating Not quite sure if it's valid, yet
Projects
None yet
Development

No branches or pull requests

2 participants