Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include src/ in public package if you're going to publish source maps #17314

Open
3 of 6 tasks
jedwards1211 opened this issue May 7, 2024 · 0 comments
Open
3 of 6 tasks
Labels
type: other For issues and PRs. Something that does not fit in any of the other "type:" labels.

Comments

@jedwards1211
Copy link
Contributor

Issue Creation Checklist

  • I understand that my issue will be automatically closed if I don't fill in the requested information
  • I have read the contribution guidelines

Bug Description

The published package has source maps but no src/ directory, so I can't just jump to where the error came from in my IDE, I have to come here, find the tag for the right version, and look in the source directory. This is tedious and painful.

Reproducible Example

What do you expect to happen?

I can jump to where the error occured by ctrl+clicking the stack trace locations in the VSCode console.

What is actually happening?

I can't, because the file in the stack trace is not included in the published package.

Environment

  • Sequelize version: 6.37.1
  • Node.js version: 20.10.0
  • If TypeScript related: TypeScript version:
  • Database & Version: Postgres 14
  • Connector library & Version: pg 8.11.3

Would you be willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.
  • Yes, I have the time but I will need guidance.
  • No, I don't have the time, but my company or I are supporting Sequelize through donations on OpenCollective.
  • No, I don't have the time, and I understand that I will need to wait until someone from the community or maintainers is interested in resolving my issue.

Indicate your interest in the resolution of this issue by adding the 👍 reaction. Comments such as "+1" will be removed.

@jedwards1211 jedwards1211 added pending-approval Bug reports that have not been verified yet, or feature requests that have not been accepted yet type: bug labels May 7, 2024
@WikiRik WikiRik added type: other For issues and PRs. Something that does not fit in any of the other "type:" labels. and removed pending-approval Bug reports that have not been verified yet, or feature requests that have not been accepted yet type: bug labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: other For issues and PRs. Something that does not fit in any of the other "type:" labels.
Projects
None yet
Development

No branches or pull requests

2 participants