Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunked_vector_test: include <optional> header #18747

Closed

Conversation

lkshminarayanan
Copy link
Member

The chunked_vector_test fails to compile with latest versions of boost(1.82 and above) due to missing include file. This patch fixes that by including the appropriate header file to the test.

Fixes #18746

The chunked_vector_test fails to compile with latest versions of boost
(1.82 and above) due to missing include file. This patch fixes that by
including the appropriate header file to the test.

Fixes scylladb#18746

Signed-off-by: Lakshmi Narayanan Sreethar <lakshmi.sreethar@scylladb.com>
Signed-off-by: Lakshmi Narayanan Sreethar <lakshmi.sreethar@scylladb.com>
@lkshminarayanan lkshminarayanan self-assigned this May 20, 2024
@lkshminarayanan lkshminarayanan added backport/5.2 backport/5.4 Issues that should be backported to 5.4 branch once they'll be fixed backport/6.0 labels May 20, 2024
Copy link
Member

@bhalevy bhalevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks

@scylladb-promoter
Copy link
Contributor

🟢 CI State: SUCCESS

✅ - Build
✅ - Unit Tests Custom
The following new/updated tests ran 100 times for each mode:
🔹 boost/chunked_vector_test
✅ - Container Test

Build Details:

  • Duration: 40 min
  • Builder: spider6.cloudius-systems.com

@michoecho
Copy link
Contributor

Duplicate of #18739.

@lkshminarayanan lkshminarayanan deleted the fix-chunked-vector-test branch May 21, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/5.4 Issues that should be backported to 5.4 branch once they'll be fixed backport/6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chunked_vector_test fails to compile with recent boost versions
4 participants