Bump redis version from <5 to <6 #460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
+ Coverage 96.27% 96.47% +0.19%
==========================================
Files 11 11
Lines 1074 1078 +4
Branches 209 190 -19
==========================================
+ Hits 1034 1040 +6
Misses 19 19
+ Partials 21 19 -2 Continue to review full report in Codecov by Sentry.
|
|
May related with: #418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #458
Just tried to bump
redisfrom<5to<6, and CI tests passed.redis 5 introduced some of incompatible API(
acloseandclose...) that made it difficult for users to change their code based on version 5, so I think bringing the version up to date it necessary.