-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
robusta-runner crashes if clusterName is read from env var in values.yaml #1205
Comments
Hey, it's not supported today. What's your motivation to do it via a tiny ConfigMap as opposed to a per-cluster Helm override value? (And are you installing w/ Flux or ArgoCD?) I'dlove to understand the use case a little more. |
Hey @aantn, thanks for your reply. We have several edge clusters all running the same apps. We use argo cd for managing the clusters. Each edge cluster contains a single kustomize file referring the template cluster and a cluster specific config map. The config map defines some cluster specific variables like the cluster name. As all of the clusters when deploying contain a config map with the same name, we can easily reference the variables from the config map. In this case it would be easy to load the value as environment variable. We do the same e.g. with prometheus for external labels. |
Any plans on supporting this soonish? |
Sorry, no update on this yet. Is this a blocker for your adoption? |
It would make the setup ways easier. As described above it reduces the cluster setup of the cloned clusters quite a lot. |
Describe the bug
I have to set the clusterName value in values.yaml file explicitly. If I read the value from an environment variable the runner crashes.
Using environment variables work in other parts of the values.yaml so it should work here too.
To Reproduce
If installed using values_error.yaml it will fail. If installed using values_success.yaml it will succeed.
values_error.yaml:
values_success.yaml:
Logs
From runner:
Expected behavior
I should be able to set any value via environment variable.
Additional context
I have robusta running in various clusters and want to be able to share as much as possible. Fully supporting environment variables in the values.yaml gives the opportunity to configure everything cluster specific in a tiny config_map.
The text was updated successfully, but these errors were encountered: