-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot use with Rack 3.0 because of Sinatra (resque-web); Blocked upgrade to Rails 7.1 #1890
Comments
Might not be a bad idea. We are about to embark on this upgrade with one app too and I think we are going to have the same problem. Going to start looking into solutions. I like the idea of splitting off resque-web into its own gem, but I want to make sure it still has the ease of use and compatibility with the rest of the plugins in the ecosystem. |
Really? We're using Rails 7.1 with Rack 2.2 just fine. |
Thank you for the confirmation that it works. Looking though the dependencies I found that this setup works
I've created a pull request that updates the README.md file to resolve this incapability and help future users. #1891 CC: @PatrickTulskie |
Sinatra 4 has been out for a while FYI |
Upgrading sinatra to version 4 appears to resolve this issue as well. I'm still testing the rails upgrade just to make sure.
|
@danlo As mentioned at #1891 (comment) , Sinatra 4.0 supports Rack 3.0, so we can use rack-session 2.0 with Rails 7.1. |
TL;DR: Rails 7.1 requires Rack 3 and Resque-web cannot support Rack 3 (due to sinatra). Can Resque-web be made into it's own gem?
Greetings,
This appears to be a partial repeat of #1492.
Sinatra cannot use Rack 3, due to the issues laid out (and in progress) here.
sinatra/sinatra#1797 (comment)
Since Sinatra cannot run rack 3; Rails 7.1 and Resque are incompatible.
@dentarg states that: sinatra/sinatra#1797 (comment)
Which suggests that Sinatra 4.x may be a while.
In the issue #1492, it was suggested that resque-web be moved into it's own separate gem
#1492 (comment)
Given, that Sinatra 4.x may be a while, could there be a release of resque w/o resque-web, so that those of us who use Resque could continue doing so on Rails 7.1?
-daniel
The text was updated successfully, but these errors were encountered: