Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR body: use html delimiters to allow appending or prepending to content #28933

Open
rarkins opened this issue May 8, 2024 · 0 comments
Open
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented May 8, 2024

Describe the proposed change(s).

We should start adding <!--renovate-pr-body-start--> before our content and <!--renovate-pr-body-end--> after it, and ignoring any content before or after that. If either tag is missing then we assume that the start or end of the content is the start or end of the PR body itself.

We should not proactively edit every existing PR and cause a lot of edits, but if we are already editing an existing PR then we should add these delimiters. If editing a PR then we should retain any content before or after.

For platforms which don't support hidden html comments, we should strip this content out, which means we don't support PR body editing on those platforms.

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

1 participant