Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to copy the source diff (raw file) #7342

Closed
x9136 opened this issue Apr 28, 2024 · 3 comments
Closed

Ability to copy the source diff (raw file) #7342

x9136 opened this issue Apr 28, 2024 · 3 comments

Comments

@x9136
Copy link

x9136 commented Apr 28, 2024

Description

During reviews, I copy svgs and paste them into Figma to check. It is often impossible to select the source diff with two clicks, because it is on different lines. It is not convenient to select with the mouse, because you need to aim accurately and move it down the code for a long time.

The 1-click option will be best, so I suggest simply duplicating the copy button from the "View file" page.
1 click option

Example URLs

https://github.com/LawnchairLauncher/lawnicons/pull/1927/files#diff-11c628f0ca4825f61a3b8b2ee690e57352ce4c4dd3cccc204b74eb599f684e32

@x9136 x9136 changed the title Copy the source diff Ability to copy the source diff Apr 28, 2024
@x9136 x9136 changed the title Ability to copy the source diff Ability to copy the source diff (raw file) Apr 29, 2024
@fregante
Copy link
Member

fregante commented Jun 5, 2024

During reviews, I copy svgs

I think that's a rare action for Refined GitHub. Perhaps I suggest:

  1. alt-click "View raw" in the dropdown
  2. drag the downloaded file to Sigma
Screenshot 2

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
@x9136
Copy link
Author

x9136 commented Jun 5, 2024

that's a rare action

Not quite. There are several PRs per month with dozens of icons. For each one, you have to do 4 actions (Open the menu → View raw → Copy → Close the tab) instead of 1, that is, 40-80 instead of 10-20. Sometimes there are PRs for 50+ icons.

An alternative could be a button: "Download the PR" on the "Files changed" page.

Then I'll wait to see what GitHub does about it.

@fregante
Copy link
Member

fregante commented Jun 5, 2024

that's a rare action

Not

We have 100k users and copy-pasting code from PRs is likely not how most people deal with code. I'm sure it's a daily occurrence for you but not for the remaining 99,999 users, so it's "a rare action for Refined GitHub"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants