Don’t configure Kamal storage volume if not needed #51838
Merged
+35
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #51836.
This Pull Request has been created because configuring a Docker persistent storage volume in Kamal seems to be only needed for sqlite or Active Storage. If using a different database and the
--skip-active-storage
option, configuration can be skipped.Detail
This Pull Request changes the
config/deploy.yml.tt
template to skip persistent storage volume configuration if skipping Active Storage and using a database that is different from sqlite.Additional information
The condition I implemented is the same as the one used here in the rails app generator.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]