Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create logfire-noop #146

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Create logfire-noop #146

wants to merge 5 commits into from

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented May 7, 2024 •
edited

Checklist

  • Test should compare the docstrings.
  • Test should compare the signatures.
  • Test should compare the __all__.

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented May 7, 2024 •
edited

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9fc7cc1
Status:🚫  Build failed.

View logs

@Kludex
Copy link
Member Author

Kludex commented May 9, 2024

We had a discussion about this... This may not be the way we want to go.

The proposed was to make logfire depend on logfire_noop.

@alexmojaki alexmojaki mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logfire-noop
1 participant
@Kludex