Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default configuration location #119

Open
danyer opened this issue May 15, 2024 · 2 comments · May be fixed by #121
Open

Default configuration location #119

danyer opened this issue May 15, 2024 · 2 comments · May be fixed by #121

Comments

@danyer
Copy link

danyer commented May 15, 2024

Hi,

thank you for wireproxy!

Is it possible to implement a default configuration location? In this way one will be able to call wireproxy without "-c config_file" and use that option only to overwrite the default one. I think ~/.config/wireproxy.conf would be a good location. Of course, to be fully XDG Base Specification compliant:
"If $XDG_CONFIG_HOME is either not set or empty, a default equal to $HOME/.config should be used."

Thank you for considering this.

@shaerpour
Copy link

@pufferffish
Is it ok to work on this and add PR?
We can add default config paths on
/etc/wireproxy/wireproxy.conf
and
$HOME/.config/wireproxy.conf.
If they does not exist, send error for getting config path option.

@pufferffish
Copy link
Owner

Is it ok to work on this and add PR?

Feel free to make a PR, I will review and merge it if it's ok

@shaerpour shaerpour linked a pull request May 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants