Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging #332

Open
smintz opened this issue May 29, 2023 · 4 comments
Open

Improve logging #332

smintz opened this issue May 29, 2023 · 4 comments
Labels
enhancement New feature or request go Pull requests that update Go code help wanted Extra attention is needed

Comments

@smintz
Copy link
Contributor

smintz commented May 29, 2023

The project isn't consistent when it comes to logging. We should choose a logging library that will give users a standard logs which will allow them integrate the logs into their preferred logging aggregator and filter them to their needs.

Some popular options:

  1. logrus
  2. zap
  3. zerolog

opinions are welcome in this discussion :)
@smintz smintz added enhancement New feature or request help wanted Extra attention is needed go Pull requests that update Go code labels May 29, 2023
@buzzdan
Copy link

buzzdan commented May 30, 2023

Many fantastic alternatives have sprung up. Logrus would look like those, had it been re-designed with what we know about structured logging in Go today. Check out, for example, Zerolog, Zap, and Apex.

^^ Logrus ^^

@avivl
Copy link
Contributor

avivl commented May 30, 2023

Logrus is in maintenance-mode.

@avivl
Copy link
Contributor

avivl commented Jun 26, 2023 •
edited

Go 1.21 (currently RC) will have slog

@smintz
Copy link
Contributor Author

smintz commented Mar 18, 2024

We decided to settle on slog. Some parts already migrated. Need to migrate all parts for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request go Pull requests that update Go code help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smintz @avivl @buzzdan