You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm serving large files directly from Cloudflare R2 by redirecting to pre-signed link for CDN benefits. See discussion.
However, with S3 or any S3 clones, you need to set Cache-Control header during file upload or modify afterwards. The current default is no caching.
I could imagine a PR would involve adding this field to all of the 4 locations and fixing any failed test. If this is the case, I'm happy to send a PR.
The text was updated successfully, but these errors were encountered:
I'm serving large files directly from Cloudflare R2 by redirecting to pre-signed link for CDN benefits. See discussion.
However, with S3 or any S3 clones, you need to set Cache-Control header during file upload or modify afterwards. The current default is no caching.
Since the
Serve
function always add cachingpocketbase/tools/filesystem/filesystem.go
Line 395 in 5acaa0a
I would like to propose that Cache-Control should be added during writing to the file system.
I'm quite new to Golang but I've done some digging:
CacheControl
is a field ofWriterOptions
and Pocketbase is currently calling this in 4 locations.I could imagine a PR would involve adding this field to all of the 4 locations and fixing any failed test. If this is the case, I'm happy to send a PR.
The text was updated successfully, but these errors were encountered: