Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: graph subscription add allow subscription for Event Hubs and Event Grid #6050

Open
MartinM85 opened this issue May 13, 2024 · 2 comments · May be fixed by #6053
Open

Enhancement: graph subscription add allow subscription for Event Hubs and Event Grid #6050

MartinM85 opened this issue May 13, 2024 · 2 comments · May be fixed by #6053
Assignees
@MartinM85
Labels
enhancement work in progress

Comments

@MartinM85
Copy link
Contributor

The command graph subscription add has validation of notificationUrl that doesn't allow to create a subscription for notifications through Azure Event Hubs and Azure Event Grid.

To allow notifications through Azure Event Hubs and Azure Event Grid, modify the validator.

notificationUrl can start with

  • https://
  • EventHub:https://
  • EventGrid:?azuresubscriptionid
@Adam-it Adam-it added enhancement needs peer review Needs second pair of eyes to review the spec or PR labels May 15, 2024
@Adam-it
Copy link
Contributor

Adam-it commented May 15, 2024

seems solid to me 👍💪
@pnp/cli-for-microsoft-365-maintainers anyone any other feed or should we open it up?

@Jwaegebaert Jwaegebaert added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels May 15, 2024
@MartinM85
Copy link
Contributor Author

I will take it

@MartinM85 MartinM85 linked a pull request May 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinM85 MartinM85

Labels
enhancement work in progress
Projects
None yet
Milestone
No milestone
3 participants
@MartinM85 @Jwaegebaert @Adam-it