[BUG] Trying to remove wiki Teams tab causes issues

[joelfmrodrigues]

Environment

[x] Office 365 / SharePoint Online

Expected or Desired Behavior

Use provisioning engine to be able to remove the Wiki tab and create new tabs in a Teams channel

Observed Behavior

When the following is present, wiki tab is not removed, and no other tabs are created/updated. No errors seem to be thrown, it fails silently

<pnp:Tab DisplayName="Wiki" TeamsAppId="com.microsoft.teamspace.tab.wiki" Remove="true" />

Steps to Reproduce

Provision a team with the following channel

<pnp:Channels>
        <pnp:Channel DisplayName="General" Description="General" IsFavoriteByDefault="true">
        </pnp:Channel>
        <pnp:Channel DisplayName="Sample Channel 01" Description="This is just a Sample Channel" IsFavoriteByDefault="true">
        </pnp:Channel>
        <pnp:Channel DisplayName="Sample Channel 02" Description="Sample Channel 02" IsFavoriteByDefault="true">
            <pnp:Tabs>
                <pnp:Tab DisplayName="Wiki" TeamsAppId="com.microsoft.teamspace.tab.wiki" Remove="true" />
                <pnp:Tab DisplayName="{parameter:Title} Projects" TeamsAppId="com.microsoft.teamspace.tab.files.sharepoint">
                    <pnp:Configuration EntityId="" ContentUrl="https://contoso.sharepoint.com/sites/mysite/Shared%20Documents" WebsiteUrl="" RemoveUrl="" />
                </pnp:Tab>
            </pnp:Tabs>
        </pnp:Channel>
    </pnp:Channels>

[ghost]

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[patrikhellgren]

You need to remove the TeamsAppId for the Wiki tab to make it work.
It should look like this:

<pnp:Tab DisplayName="Wiki" TeamsAppId="" Remove="true" />

Graph doesn't return a TeamsAppId for the Wiki tab and PnP Provisioning uses this and the name to match the tab to remove. You can try this yourself in Graph Explorer.
Not sure if this has anything to do with the other tab not being added but at least you should see the Wiki tab being removed.

[joelfmrodrigues]

@patrikhellgren Thank you! That did the trick to remove the Tab 😀
I think it would still be nice to get an error (or perhaps ignore the property within the engine?) as the silent failure can be really hard to troubleshoot for someone not aware of the TeamsAppId trick - like me

Love this engine 🥰