Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected full reload using info schema cache v2 #53406

Closed
wjhuang2016 opened this issue May 20, 2024 · 2 comments
Closed

Unexpected full reload using info schema cache v2 #53406

wjhuang2016 opened this issue May 20, 2024 · 2 comments
Labels
type/bug This issue is a bug.

Comments

@wjhuang2016
Copy link
Member

wjhuang2016 commented May 20, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Set DefTiDBSchemaCacheSize to 10 to enable info schema cache.
Run test TestModifyColumnBetweenStringTypes and check log

2. What did you expect to see? (Required)

Only some full load in log.

3. What did you see instead (Required)

image 1034 times `full load`

4. What is your TiDB version? (Required)

master

@wjhuang2016 wjhuang2016 added the type/bug This issue is a bug. label May 20, 2024
@tiancaiamao
Copy link
Contributor

1034 times full load? which version are you using?

I test with latest master and see only 6 times:

commit b7e32bcf9994f0fc916c59e6d5f573a39127d105 (HEAD -> master, origin/master, origin/HEAD)
Author: Yuanjia Zhang <zhangyuanjia@pingcap.com>
Date:   Mon May 20 17:47:46 2024 +0800

    planner: fix the wrong result caused by `year_col cmp out-of-range-uint` (#53395)
    
    close pingcap/tidb#50235
go test -tags intest -run  TestModifyColumnBetweenStringTypes > a.log
grep 'full load' a.log 
[2024/05/20 21:18:17.236 +08:00] [INFO] [domain.go:322] ["full load InfoSchema success"] [currentSchemaVersion=0] [neededSchemaVersion=0] ["start time"=8.288048ms]
[2024/05/20 21:18:17.238 +08:00] [INFO] [domain.go:642] ["full load and reset schema validator"]
[2024/05/20 21:18:17.255 +08:00] [INFO] [domain.go:322] ["full load InfoSchema success"] [currentSchemaVersion=0] [neededSchemaVersion=1] ["start time"=8.667917ms]
[2024/05/20 21:18:17.256 +08:00] [INFO] [domain.go:642] ["full load and reset schema validator"]
[2024/05/20 21:18:17.966 +08:00] [INFO] [domain.go:322] ["full load InfoSchema success"] [currentSchemaVersion=0] [neededSchemaVersion=51] ["start time"=14.079266ms]
[2024/05/20 21:18:17.972 +08:00] [INFO] [domain.go:642] ["full load and reset schema validator"]

@wjhuang2016
Copy link
Member Author

It's caused by unexpected code introduced in my test branch, and this problem doesn't exist in the master branch,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants