Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YFinanceTools().get_historical_stock_prices returns only one datapoint #307

Open
rawmean opened this issue May 16, 2024 · 3 comments
Open

Comments

@rawmean
Copy link

rawmean commented May 16, 2024

To test, do this and observe that only one datapoint is returns (instead of the default which should be daily for one month). I also tried different values for period and interval parameters.

data = YFinanceTools().get_historical_stock_prices(symbol="NVDA")  
print(data)
@rawmean
Copy link
Author

rawmean commented May 17, 2024

#308

@ysolanky
Copy link
Contributor

Thanks for the PR @rawmean. Sometimes the LLM would request historical data across a long interval (5 years+) exceeding the context window of some of the smaller models. But happy to test this and set some checks to avoid that.

@rawmean
Copy link
Author

rawmean commented May 17, 2024

Thanks. 5+ years interval may not be necessarily large if the period is set to 1mo as an example. If you insist on putting a check, maybe the check should be on number of samples and not the "interval".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants