Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study impact of Soundcloud API changes #465

Open
2 tasks
adrienjoly opened this issue Aug 2, 2021 · 2 comments
Open
2 tasks

Study impact of Soundcloud API changes #465

adrienjoly opened this issue Aug 2, 2021 · 2 comments

Comments

@adrienjoly
Copy link
Member

adrienjoly commented Aug 2, 2021

According to an email I received today (see below), Soundcloud are securing access to their API, causing breaking changes on several endpoint that Openwhyd and PlayemJS use. One of these changes may break calls that we make from the front-end by just passing a client_id parameter to Soundcloud's endpoints. If we need to send a secret with that ID, this means that we may have to move some of those calls to the back-end. (or maybe not)

Tasks

  • Before updating anything, let's find out what may need to be updated on Openwhyd and PlayemJS, and what problem it may cause if we don't update.
  • After fixing the problem, also re-enable the lookup test disabled in PR fix(tests): lookup external tracks #469

Email received today from Soundcloud:

Dear partner / API user,

If you are not calling api.soundcloud.com you can stop reading right here. Otherwise, there are a number of updates that might require actions from your side.

At the beginning of July, we announced security updates to our API, mainly how we deal with auth. Please read a blog post to know more about the changes.

We understand that it’s a lot and might require some time on your side to update the systems. We would appreciate it if you could start working on it ASAP, as some of the changes are live already.

Deprecation of client_id and the requirement to provide an Authorization header for each request is the biggest update. We are planning to start slowly rolling it out in September. Meaning that some percentage of requests will start failing if the header is not present.

If you have no capacity to update your systems in the following 1-2 months please let us know. We will try to find a solution. We definitely do not want to create a bad experience for users.

For any further questions please do not hesitate to contact us. You can comment on this thread, or create a new ticket.

Best,

Soundcloud Team

@adrienjoly
Copy link
Member Author

Soundcloud's API change may explain this failing test:

  1) Openwhyd
       should allow users to search external tracks:
     AssertionError: Timed out retrying after 4000ms: Expected to find element: `a[onclick="window.goToPage('/sc/harissaquartet/no-service');return false;"]`, but never found it.
      at Context.eval (http://localhost:8080/__cypress/tests?p=cypress/integration/acceptance.spec.ts:250:14)

source: https://github.com/openwhyd/openwhyd/pull/468/checks?check_run_id=3371392720#step:7:130

adrienjoly added a commit that referenced this issue Aug 19, 2021
## Problem

E2e test "`Openwhyd should allow users to search external tracks`" [fails on CI](https://github.com/openwhyd/openwhyd/pull/468/checks?check_run_id=3371392720#step:7:130):

```
  1) Openwhyd
       should allow users to search external tracks:
     AssertionError: Timed out retrying after 4000ms: Expected to find element: `a[onclick="window.goToPage('/sc/harissaquartet/no-service');return false;"]`, but never found it.
      at Context.eval (http://localhost:8080/__cypress/tests?p=cypress/integration/acceptance.spec.ts:250:14)
```

Could be caused by recent Soundcloud API change. (see #465)

## Proposed solution

- Temporary fix: disable this test
- To prevent regressions on lookup of external track until we fix that test: add a test to lookup MP3 file.
adrienjoly pushed a commit that referenced this issue Aug 19, 2021
## [1.44.44](v1.44.43...v1.44.44) (2021-08-19)

### Bug Fixes

* **tests:** lookup external tracks ([#469](#469)) ([5169df2](5169df2)), closes [#465](#465)
@adrienjoly
Copy link
Member Author

related issue: #614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant