Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stricter parser for ipv4_from_asc #24432

Open
amiremohamadi opened this issue May 17, 2024 · 1 comment
Open

stricter parser for ipv4_from_asc #24432

amiremohamadi opened this issue May 17, 2024 · 1 comment
Labels
branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug triaged: feature The issue/pr requests/adds a feature

Comments

@amiremohamadi
Copy link
Contributor

thanks to @davidben for identifying the issue, there's a problem in the ipv4_from_asc function. currently we accept these invalid inputs:

"1.2.3. 4"
"1.2.3.+4"

https://boringssl-review.googlesource.com/c/boringssl/+/68567
@amiremohamadi amiremohamadi added the issue: bug report The issue was opened to report a bug label May 17, 2024
@davidben
Copy link
Contributor

(OpenSSL folks, you are welcome to treat that change as a contribution under CLA, if you like.)

@t8m t8m added branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug triaged: feature The issue/pr requests/adds a feature and removed issue: bug report The issue was opened to report a bug labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidben @t8m @amiremohamadi