Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist net request issues #1609

Closed
trudnorx opened this issue May 20, 2024 · 1 comment
Closed

Playlist net request issues #1609

trudnorx opened this issue May 20, 2024 · 1 comment
Labels
bug This issue identifies a bug in Nuclear.

Comments

@trudnorx
Copy link

trudnorx commented May 20, 2024

Platform: Any

Nuclear version: Latest

Description of the issue:

  1. Every time a playlist is loaded, nuclear immediately starts making network requests for every item in the playlist (e.g. searching YT). This quickly adds up to several MBs of data for large playlists. It may be more sensible to only make requests for the current plus next track or 5-10 tracks next to the currently playing one.
  2. This also applies to track images, though these take much less data than the YT searches. For images something similar could be done but based on how far the user has scrolled.
  3. Nuclear makes stream verification requests even if the user disables these.
  4. This info (points 1-3) doesn't seem to persist across sessions, so the next time you play that same playlist, nuclear needs to make all these requests again.
@trudnorx trudnorx added the bug This issue identifies a bug in Nuclear. label May 20, 2024
@trudnorx trudnorx changed the title Playlist issues Playlist net request issues May 20, 2024
@nukeop nukeop closed this as completed in b1533c5 May 21, 2024
@nukeop
Copy link
Owner

nukeop commented May 21, 2024

  1. It makes for a better user experience if the streams for the whole playlist are retrieved in the background one by one, it allows for (almost) seamless playback. It's a miniscule amount of data, compared to the actual audio streams, and it's just one track at a time.
  2. Images are already fetched by the time you add them to the queue, so no extra requests are needed.
  3. This was a bug, I fixed it now.
  4. The retrieved stream URLs are ephemeral and need to be refreshed because they expire within a short time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue identifies a bug in Nuclear.
Projects
None yet
Development

No branches or pull requests

2 participants