-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement window.transparent
configuration option for Windows
#1201
Comments
window.transparent
option for Windowswindow.transparent
configuration option for Windows
Hi I would like to work on this issue, Can you please explain this issue a bit ? |
Thanks so much for your interest @FireNdIce3. I've update the issue description. Please check and let us know if you have more questions 🎉 |
Sure! |
Hi @shalithasuranga , |
Hi @officeneerajsaini, thanks so much for your interest. Please check the updated issue description. This issue requires writing some Windows-specific code, so it needs to be compiled on Windows. Maybe you can use a Windows VM on Linux? |
So, do we fix this issue now, or wait for the GSoC proposal? I found just one problem in this GSoC-related repository; are there any more things we need to look into |
@officeneerajsaini This task is not a GSoC 2024 task, so contributors can work on this issue and send pull requests -- you also can send a pull request for this one even before sending a proposal (We've mentioned about this on Discrod). Note: Btw, this issue requires some experience in Neutralinojs internals, so if you are getting started with the codebase, you can find other issue that has the |
Very well then, I am so excited to work on this issue. I have some experience in open source; just a few days ago, I merged my pull request on Node.js documentation issues. For this contribution, I need your help to resolve this issue. Could you please explain the details of this issue? |
Great @officeneerajsaini, I recently updated this issue's description with the goal of this task. We basically need to implement the missing Window/webview transparency feature for the Windows platform. It's already done for other two platforms. Please let me know if you have questions regarding task details 🎉 Thanks |
Hi @shalithasuranga |
Hi @officeneerajsaini , I'm curious to see how the issue develops. |
is this issue still open ? |
@officeneerajsaini yes but it can be closed. The feature was added in a Pullrequest already. |
sorry for delay reply |
Currently, the
window.transparent
config prop is only implemented in GNU/Linux and macOS as follows:webview.h
file and the webview transparency is set in the same file.macwindow.mm
file and the webview transparency is set in thewebview.h
fileSimilarly, we need to implement this conditional transparency feature in Windows too.
The text was updated successfully, but these errors were encountered: