Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement window.transparent configuration option for Windows #1201

Open
shalithasuranga opened this issue Feb 17, 2024 · 14 comments · May be fixed by #1250
Open

Implement window.transparent configuration option for Windows #1201

shalithasuranga opened this issue Feb 17, 2024 · 14 comments · May be fixed by #1250

Comments

@shalithasuranga
Copy link
Member

shalithasuranga commented Feb 17, 2024

Currently, the window.transparent config prop is only implemented in GNU/Linux and macOS as follows:

  • GNU/Linux: Window transparency is set in the webview.h file and the webview transparency is set in the same file.
  • macOS: Window transparency is set in the macwindow.mm file and the webview transparency is set in the webview.h file

Similarly, we need to implement this conditional transparency feature in Windows too.

@shalithasuranga shalithasuranga changed the title Implement window.transparent option for Windows Implement window.transparent configuration option for Windows Feb 17, 2024
@FireNdIce3
Copy link

Hi I would like to work on this issue, Can you please explain this issue a bit ?
Thanks

@shalithasuranga
Copy link
Member Author

Thanks so much for your interest @FireNdIce3. I've update the issue description. Please check and let us know if you have more questions 🎉

@FireNdIce3
Copy link

Sure!
Thanks

@officeneerajsaini
Copy link

Hi @shalithasuranga ,
I want to work on this issue. Could you please provide more details about the problem? Additionally, I am a Linux user; am I able to contribute to the resolution of this issue?

@shalithasuranga
Copy link
Member Author

Hi @officeneerajsaini, thanks so much for your interest. Please check the updated issue description. This issue requires writing some Windows-specific code, so it needs to be compiled on Windows. Maybe you can use a Windows VM on Linux?

@officeneerajsaini
Copy link

So, do we fix this issue now, or wait for the GSoC proposal? I found just one problem in this GSoC-related repository; are there any more things we need to look into

@shalithasuranga
Copy link
Member Author

shalithasuranga commented Feb 22, 2024

@officeneerajsaini This task is not a GSoC 2024 task, so contributors can work on this issue and send pull requests -- you also can send a pull request for this one even before sending a proposal (We've mentioned about this on Discrod).

Note: Btw, this issue requires some experience in Neutralinojs internals, so if you are getting started with the codebase, you can find other issue that has the gsoc label on it in other repos as well.

@officeneerajsaini
Copy link

@officeneerajsaini This task is not a GSoC 2024 task, so contributors can work on this issue and send pull requests -- you also can send a pull request for this one even before sending a proposal (We've mentioned about this on Discrod).

Note: Btw, this issue requires some experience in Neutralinojs internals, so if you are getting started with the codebase, you can find other issue that has the gsoc label on it in other repos as well.

Very well then, I am so excited to work on this issue. I have some experience in open source; just a few days ago, I merged my pull request on Node.js documentation issues. For this contribution, I need your help to resolve this issue. Could you please explain the details of this issue?

@shalithasuranga
Copy link
Member Author

Great @officeneerajsaini, I recently updated this issue's description with the goal of this task. We basically need to implement the missing Window/webview transparency feature for the Windows platform. It's already done for other two platforms. Please let me know if you have questions regarding task details 🎉 Thanks

@FireNdIce3
Copy link

FireNdIce3 commented Feb 22, 2024

Hi @shalithasuranga
I'd be also working on this issue, I'd like to contribute in GSoC as well but I think understanding the codebase first will be better and solving this issue would be a great opportunity to start!
Thanks

@bxsti-dev
Copy link

bxsti-dev commented Apr 30, 2024

I am so excited to work on this issue

Hi @officeneerajsaini ,
do you still planing to work on that issue?
Seems like it can't be done for gsoc.
What is the current state of this Issue?

I'm curious to see how the issue develops.
Thanks

@ArcticFqx ArcticFqx linked a pull request May 4, 2024 that will close this issue
@officeneerajsaini
Copy link

is this issue still open ?

@bxsti-dev
Copy link

@officeneerajsaini yes but it can be closed. The feature was added in a Pullrequest already.

@officeneerajsaini
Copy link

I am so excited to work on this issue

Hi @officeneerajsaini , do you still planing to work on that issue? Seems like it can't be done for gsoc. What is the current state of this Issue?

I'm curious to see how the issue develops. Thanks

sorry for delay reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants