Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft OneDrive Trigger - Watch Nested Folders results in error #9328

Open
bryantlee opened this issue May 7, 2024 · 5 comments
Open
Labels

Comments

@bryantlee
Copy link

Bug Description

No issues on watching a folder by ID. But the moment I click on "Watch Nested Folders" - I get the following error:

{ "errorMessage": "Cannot read properties of undefined (reading 'startsWith')", "errorDetails": {}, "n8nDetails": { "n8nVersion": "1.37.3 (Self Hosted)", "binaryDataMode": "default", "stackTrace": [ "TypeError: Cannot read properties of undefined (reading 'startsWith')", " at /usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/Microsoft/OneDrive/MicrosoftOneDriveTrigger.node.js:92:88", " at Array.filter (<anonymous>)", " at Object.poll (/usr/local/lib/node_modules/n8n/node_modules/n8n-nodes-base/dist/nodes/Microsoft/OneDrive/MicrosoftOneDriveTrigger.node.js:92:45)", " at processTicksAndRejections (node:internal/process/task_queues:95:5)", " at Workflow.runNode (/usr/local/lib/node_modules/n8n/node_modules/n8n-workflow/dist/Workflow.js:747:32)", " at /usr/local/lib/node_modules/n8n/node_modules/n8n-core/dist/WorkflowExecute.js:660:53", " at /usr/local/lib/node_modules/n8n/node_modules/n8n-core/dist/WorkflowExecute.js:1062:20" ] } }

image

To Reproduce

  1. Configure MSFT OneDrive Trigger
  2. Trigger on "File Created"
  3. Enable Watch Folder
  4. Enter Folder ID
  5. Enable Watch Nested Folders

Expected behavior

Ability to get events for nested folders in OneDrive folder

Operating System

Official Docker

n8n Version

1.37.3

Node.js Version

v18.19.1.

Database

SQLite (default)

Execution mode

main (default)

@Joffcom
Copy link
Member

Joffcom commented May 14, 2024

Hey @bryantlee,

Thanks for the report, I have popped in a PR that should resolve this and will be available in a future release once reviewed and merged.

@bryantlee
Copy link
Author

thank you!

@Joffcom
Copy link
Member

Joffcom commented May 14, 2024

I am not sure if you already noticed but the error only appears when testing so you can still activate your workflow and it should work.

@bryantlee
Copy link
Author

I noticed you mention during testing in your pr. I've already worked around it but great to know I can simplify my flow soon. Thanks!

@janober
Copy link
Member

janober commented May 22, 2024

Fix got released with n8n@1.43.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants