Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete menu is not visible #6747

Open
3 of 11 tasks
DevelopmentAnything opened this issue May 16, 2024 · 7 comments
Open
3 of 11 tasks

Delete menu is not visible #6747

DevelopmentAnything opened this issue May 16, 2024 · 7 comments

Comments

@DevelopmentAnything
Copy link
Contributor

MMEX version:

  • 1.7.0
  • 1.8.0
  • 1.8.1 b1
  • 1.8.2
  • Other (please specify)

Note: bug reporters are expected to have verified the bug still exists
either in the last stable version of MMEX or on updated development code
(master branch).

Operating System:

  • Windows
  • Mac OSX
  • Linux

Description of the bug

Please describe your issue with details.
Add screenshot or other files if needed.

image

langs: en-US, ko-KR, ...

empty menus... but can click menus

Reproduction

Is the bug reproducible?

  • Always
  • Randomly
  • Happened only once

Reproduction steps:

transaction grid
open context popup - delete sub menu

Expected result:

visible menus

Actual result:

empty string

Additional information

If you have a backtrace for a crash or a warning, paste it here.

@renato-mmex
Copy link

On this homepage, users can make the translations themselves.
https://crowdin.com/project/moneymanagerex

@DevelopmentAnything
Copy link
Contributor Author

@renato-mmex
It's a different answer from the topic.
And please point out exactly what hasn't been translated. There are only 3 that I haven't translated.

@renato-mmex
Copy link

Sorry, it concerns the translations. I checked it in my German version and found that the texts are displayed in English, although I translated them into German.
It seems that there is a problem with the assignment of the texts.
image

@ovari
Copy link
Contributor

ovari commented May 16, 2024

Crowdin is yet to be updated with the English source strings. @vomikan might be able to advise when the update is expected.

@n-stein
Copy link
Contributor

n-stein commented May 16, 2024

Keyboard shortcuts were recently added, so the strings need to be pulled into Crowdin and retranslated:

700dbdd
bf04a48

@n-stein
Copy link
Contributor

n-stein commented May 16, 2024

The empty menus you see are probably because because the commits I referenced above changed the ASCII character " to the Unicode characters U+201C and U+201D “ ”, but the escape characters \ were left in (when there is now nothing to escape). This results in an incorrect byte sequence when trying to convert to a wxString.

However, we also can't just drop Unicode characters directly into the source strings and expect them to work -- you have to explicitly tell wxWidgets to interpret it as UTF-8. Otherwise it gets interpreted according to the standard encoding of your operating system, which for Windows is UTF-16 and not UTF-8. This results in odd results like:

image

So to use Unicode characters in a translated string you have to do something like this:

wxGetTranslation(wxString::FromUTF8(wxTRANSLATE("Delete Viewed “&Follow Up” Transactions...")))

Honestly its simpler and cleaner to just use the normal " character...

@ovari
Copy link
Contributor

ovari commented May 17, 2024

So to use Unicode characters in a translated string you have to do something like this:

wxGetTranslation(wxString::FromUTF8(wxTRANSLATE("Delete Viewed “&Follow Up” Transactions...")))

Thank you for the tip, done at b15da26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants