Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cashflow transactions doubling income payments #6745

Open
swjpanton opened this issue May 15, 2024 · 6 comments
Open

Cashflow transactions doubling income payments #6745

swjpanton opened this issue May 15, 2024 · 6 comments
Assignees
Milestone

Comments

@swjpanton
Copy link

I have scheduled income transactions see attached screenshot
screenshot 1.pdf
1.pdf

today is 15 May
It is reconciled in my account: screenshot 2
screenshot 2.pdf

In reports/Cashflow/transactions it is also showing. see screenshot 3.pdf
screenshot 3.pdf

This means it is effectively doubling the balance in that account for today. therefore the projected cashflow is wrong.

To help if i changed the reconciled date to yesterday the balance is corrected the cashlow/transactions has removed the two credits seen in screenshot 3. see screenshot 4 and the cashflow is corrected.
screenshot 4.pdf

hope this has provided enough info. Many thanks
simon Panton

Please do not remove information attached below this text.


• Version: 1.8.0 64-bit
• Built: Apr 29 2024 08:12:03
• db 19 (aes128cbc)
• git 3325705 (2024-04-29)
• master

Libs:
• wxWidgets 3.2.4 (wxMac 14.4)
• wxSQLite3 4.9.1 (SQLite 3.40.0)
• RapidJSON 1.1.0
• Lua 5.3.5
• libcurl/8.4.0 (SecureTransport) LibreSSL/3.3.6 zlib/1.2.12 nghttp2/1.58.0
• gettext 0.22.5
• apexcharts.js

Built with:
• CMake 3.28.3
• GNU Make 3.81
• Clang Apple LLVM 15.0.0 (clang-1500.3.9.4)

OS:
• macOS Sonoma Version 14.4.1 (Build 23E224)
• System Locale:
• User Interface Language: en_GB.Western (Mac OS Roman)
• 1344x840 32-bit 144x144ppi
@pfbreton-perso
Copy link

I found this problem as well today. Income today counted twice in the cashflow report

@swjpanton
Copy link
Author

The above bug also applies to debits reconciled on the day too.

n-stein added a commit to n-stein/moneymanagerex that referenced this issue May 16, 2024
@n-stein
Copy link
Contributor

n-stein commented May 16, 2024

This was an artifact of the addition of transaction time. The report pulled the current balance based on the end of today, then pulled the future transactions based on the start of today, so items for "today" were incorrectly included in both.

I have adjusted the report as well as some bugs I found on the home screen and checking panel related to the display of "future" transactions.

Now same-dated transactions in the future are marked as such if time is enabled and the time portion of the transaction is in the future:

image

or if time is disabled:

image

This also adjusts the balance calculations in the account view and home screen if "Ignore future transactions" is enabled. If you enable transaction time but ignore future transactions, the dashboard shows you the account values as of "now". So if you log a transaction for today but set the time in the future it is excluded from account views/balances until that time, the same as if the date portion was set in the future.

@n-stein
Copy link
Contributor

n-stein commented May 16, 2024

@swjpanton if you have some time please give the beta a try once the AppVeyor build is complete and confirm it is behaving as expected:

https://ci.appveyor.com/project/whalley/moneymanagerex/builds/49830886

@n-stein n-stein self-assigned this May 16, 2024
@n-stein n-stein added the bug label May 16, 2024
@n-stein n-stein added this to the v1.8.1 milestone May 16, 2024
@swjpanton
Copy link
Author

swjpanton commented May 18, 2024 via email

@n-stein
Copy link
Contributor

n-stein commented May 18, 2024

Sorry, just realized you're on macOS. @whalley will publish the beta build at https://link.ipx.co.uk/mmex-mac-betas once the changes have been merged

vomikan added a commit that referenced this issue May 18, 2024
fix(#6745): handle future transactions according to time
@n-stein n-stein added the fixed label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants