Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See if it's possible to de-duplicate undo command code #172

Open
mitchcurtis opened this issue Aug 7, 2021 · 0 comments
Open

See if it's possible to de-duplicate undo command code #172

mitchcurtis opened this issue Aug 7, 2021 · 0 comments
Labels

Comments

@mitchcurtis
Copy link
Owner

mitchcurtis commented Aug 7, 2021

For the commands that just take a new and old image (or set of images, in the case of layers), we should see if it's possible to reduce them down to more generic commands that just take an image (or set of images). To do this we have to check that the commands can still be accurately represented in a history panel (undo view). To do that we need a model that can represent undo actions:

https://bugreports.qt.io/browse/QTBUG-95640

As we use macros (for reasons I don't remember), it should be possible to use the text of each macro to identify the command, even after removing the duplicate classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant