Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new greptimedb handler #9071

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sunng87
Copy link

@sunng87 sunng87 commented Apr 13, 2024

Description

Please include a summary of the change and the issue it solves.

Fixes #9066

Type of change

(Please delete options that are not relevant)

  • ⚡ New feature (non-breaking change which adds functionality)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

Verified via add greptimedb as a valid datasource

CREATE DATABASE greptimedb_datasource
WITH
  engine = 'greptimedb',
  parameters = {
    "host": "127.0.0.1",
    "port": 4002,
    "database": "public",
    "user": "username",
    "password": "password"
  };

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.

@mindsdbadmin
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

Copy link
Member

@ZoranPandovski ZoranPandovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please just sign the CLA and check the flake warning https://github.com/mindsdb/mindsdb/actions/runs/8676900511/job/24367927062?pr=9071#step:6:76

@sunng87
Copy link
Author

sunng87 commented Apr 29, 2024

I have read the CLA Document and I hereby sign the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Integration] GreptimeDB database integration
3 participants