Enable enums in @PrimaryKey?

[boenrobot]

Right now, if you have a primary key property that is also an enum (be it the sole PK, or, more realistically, as part of a composite PK), you can only declare it via

@Enum({ items: () => EnumItems, primary: true });

Whereas
@PrimaryKey({ items: () => EnumItems });

Fails with a type error, since "items" is only defined in @Enum.

Should PrimaryKeyOptions be modified to inherit from EnumOptions instead of PropertyOptions maybe?

---

I found this by running the entity generator, which generates the second snippet... I'm wondering whether to try and fix that to be the first snippet... Or maybe change the decorator, so that the second snippet, as already generated, becomes working.

[B4nan]

Generally speaking, people should use the first variant, it's the same with FK as PK, you also need to use the relation decorator with primary: true instead.

Should PrimaryKeyOptions be modified to inherit from EnumOptions instead of PropertyOptions maybe?

That would mean we also allow array PKs which we surely don't and won't. I am not completely opposed to adding the items option to the PK options, but it feels a bit weird, I wouldn't expect that to produce an enum column really.

[boenrobot]

Ah... FK as PK... Didn't even think of that... Ok, makes sense. In that light, I agree, adding anything beyond "Property" to PrimaryKey is a bit weird, since other decorators with "primary" are already needed.