Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: FunctionCallingStepwisePlanner not working in semantic-kernel 1.0.0rc1 | programming language python #6333

Closed
rvishwakarma001 opened this issue May 19, 2024 · 2 comments · Fixed by #6337
Closed

Python: FunctionCallingStepwisePlanner not working in semantic-kernel 1.0.0rc1 | programming language python #6333

rvishwakarma001 opened this issue May 19, 2024 · 2 comments · Fixed by #6337
Labels
python Pull requests for the Python Semantic Kernel triage

Comments

@rvishwakarma001
Copy link

Describe the bug
I have implemented to test FunctionCallingStepwisePlanner but got below issue:
An error occurred during planner invocation: OpenAIChatCompletionBase._process_function_call() got an unexpected keyword argument 'result'

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
It should work.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform

  • OS: Windows
  • IDE: VS Code
  • Language: Python
  • Source: semantic-kernel 1.0.0rc1

Additional context
semantic_kernel\planners\function_calling_stepwise_planner\function_calling_stepwise_planner.py
result param is not used in chat_completion._process_function_call method that need to fix
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel triage labels May 19, 2024
@github-actions github-actions bot changed the title FunctionCallingStepwisePlanner not working in semantic-kernel 1.0.0rc1 | programming language python Python: FunctionCallingStepwisePlanner not working in semantic-kernel 1.0.0rc1 | programming language python May 19, 2024
@cory-orennia
Copy link

Can confirm encountering the same issue.

@rvishwakarma001
Copy link
Author

Can confirm encountering the same issue.

Yes

@eavanvalkenburg eavanvalkenburg mentioned this issue May 20, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue May 20, 2024
@eavanvalkenburg @moonbox3
Python: fix for fc stepwise (#6337)
2581350 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
fixes #6333 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python Pull requests for the Python Semantic Kernel triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python: fix for fc stepwise eavanvalkenburg/semantic-kernel
3 participants
@cory-orennia @rvishwakarma001 @markwallace-microsoft