Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs from Forks won't have Access to Secrets #452

Open
martinpeck opened this issue Apr 2, 2024 · 1 comment
Open

PRs from Forks won't have Access to Secrets #452

martinpeck opened this issue Apr 2, 2024 · 1 comment

Comments

@martinpeck
Copy link
Member

The GitHub action rag_exp_acc_ci runs on PRs.
However, because PRs from forks aren't given secrets, this action will fail for all such PRs.

This project needs to address this if PRs from forks are expected (i.e. any external contribution)

Ways to work around this include the approach taken by Azure TRE where by a PR bot is used to kick of builds of PRs only after inspection of the PR to ensure that secrets won't be exposed:

https://github.com/microsoft/AzureTRE/blob/main/.github/workflows/pr_comment_bot.yml

@martinpeck
Copy link
Member Author

Alternatively, don't run builds that require secrets against PRs. Only run them against branches, once merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant